Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

공통 컴포넌트: ScrollToTop #126

Merged
merged 7 commits into from
Jan 24, 2024
Merged

공통 컴포넌트: ScrollToTop #126

merged 7 commits into from
Jan 24, 2024

Conversation

bottlewook
Copy link
Collaborator

@bottlewook bottlewook commented Jan 23, 2024 •
edited
Loading

해당 사항 (중복 선택)

  • FEAT : 새로운 기능 추가 및 개선
  • TEST : 테스트 추가 및 리팩토링
  • FIX : 버그 수정
  • REFACTOR : 결과의 변경 없이 코드의 구조를 재조정
  • STYLE : 코드 스타일에 관련된 변경 사항
  • DOCS : 코드가 아닌 문서를 수정한 경우
  • REMOVE : 파일을 삭제하는 작업만 수행
  • RENAME : 파일 또는 폴더명을 수정하거나 위치(경로)를 변경
  • CHORE : 패키지 매니저 설정, 코드 수정 없이 설정 변경(eslint) 등 기타 사항

설명

Key Changes

  1. ScrollToTop 컴포넌트 제작
  2. useScrollToTop 커스텀 훅 제작

How it Works

To Reviewers

  • throttle을 적용하기 위해 lodash 라이브러리 설치했습니다
  • 디자인은 추후에 변경할 예정입니다!

@bottlewook bottlewook added the ✨ Feature 기능 개발 label Jan 23, 2024
@bottlewook bottlewook self-assigned this Jan 23, 2024
@bottlewook bottlewook requested a review from seoye0ng as a code owner January 23, 2024 15:10
@bottlewook bottlewook linked an issue Jan 23, 2024 that may be closed by this pull request
공통 컴포넌트: ScrollTop #123
Closed
1 task
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
f1-wash-pedia-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 3:06pm

bottlewook
bottlewook commented Jan 23, 2024
View reviewed changes
Copy link
Collaborator Author

@bottlewook bottlewook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

셀프 코드리뷰

src/components/shared/scroll-to-top/ScrollToTop.tsx Outdated

import classNames from 'classnames/bind';

import Expand from '@/components/icons/Expand';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import Expand from '@/components/icons/Expand';
import Expand from '@components/icons/Expand';

src/app/page.tsx Outdated Show resolved Hide resolved
seoye0ng
seoye0ng reviewed Jan 24, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
seoye0ng
seoye0ng requested changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@seoye0ng seoye0ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@bottlewook bottlewook merged commit 3735f44 into develop Jan 24, 2024
6 checks passed
@bottlewook bottlewook deleted the common-component-scroll-top branch January 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seoye0ng seoye0ng seoye0ng requested changes

Assignees

@bottlewook bottlewook

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

공통 컴포넌트: ScrollTop
2 participants
@bottlewook @seoye0ng